Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0-beta1
    • Component/s: javascript-dojo
    • Labels:

      Description

      The support for Dojo 1.7.1 and beyond should be updated to use the new AMD module format.

      Perhaps in this process it would also make sense to update to use dojox/socket

        Activity

        Hide
        bwa added a comment - - edited

        I have copied all the 1.7.2/dojox to local and merged in cometd from cometd 2.5. Now I'm getting a GET /js/org/cometd.js and this file is not found, and it shall not exist ? See attached screenshot-1

        Show
        bwa added a comment - - edited I have copied all the 1.7.2/dojox to local and merged in cometd from cometd 2.5. Now I'm getting a GET /js/org/cometd.js and this file is not found, and it shall not exist ? See attached screenshot-1
        Hide
        Simone Bordet added a comment -

        Good catch !

        I think that CometD's Dojo binding should move to /dojox/cometd/main.js instead of dojox/cometd.js.
        In this way, you can map in the packages configuration just for CometD, keeping all the rest at the CDN.

        require({
                packages: [{
                    name: 'dojox/cometd',
                    location: '/dojox/cometd'
                },{
                    name: 'org',
                    location: '/org'
                }]
            },
            ...
        );
        

        Let me try this solution.

        Show
        Simone Bordet added a comment - Good catch ! I think that CometD's Dojo binding should move to /dojox/cometd/main.js instead of dojox/cometd.js . In this way, you can map in the packages configuration just for CometD, keeping all the rest at the CDN. require({ packages: [{ name: 'dojox/cometd', location: '/dojox/cometd' },{ name: 'org', location: '/org' }] }, ... ); Let me try this solution.
        Hide
        Simone Bordet added a comment -

        I think that for /js/org/cometd.js you have another configuration problem that is independent from this one.

        Show
        Simone Bordet added a comment - I think that for /js/org/cometd.js you have another configuration problem that is independent from this one.
        Hide
        bwa added a comment -

        Hey, this support i FAST ! Great.
        I have updated the package ref to /dojox/cometd, and have only dojox/cometd (and org) locally. But now I miss two files ... :

        "NetworkError: 404 Not Found - https://localhost:9451/ASAPTrigger/js/dojox/cometd/main.js"
        "NetworkError: 404 Not Found - https://localhost:9451/ASAPTrigger/js/org/cometd.js"

        I don't understand where these references come from....

        Show
        bwa added a comment - Hey, this support i FAST ! Great. I have updated the package ref to /dojox/cometd, and have only dojox/cometd (and org) locally. But now I miss two files ... : "NetworkError: 404 Not Found - https://localhost:9451/ASAPTrigger/js/dojox/cometd/main.js " "NetworkError: 404 Not Found - https://localhost:9451/ASAPTrigger/js/org/cometd.js " I don't understand where these references come from....
        Hide
        Simone Bordet added a comment -

        Please comment on COMETD-375.

        Show
        Simone Bordet added a comment - Please comment on COMETD-375 .

          People

          • Assignee:
            Simone Bordet
            Reporter:
            Dylan Schiemann
          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: